feat(foreground): Add foreground command#281
Merged
hubertdeng123 merged 21 commits intomainfrom Jun 3, 2025
Merged
Conversation
hubertdeng123
changed the base branch from
main
to
hubertdeng123/add-supervisor-to-down
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## main #281 +/- ##
==========================================
+ Coverage 95.08% 95.13% +0.05%
==========================================
Files 27 28 +1
Lines 2379 2468 +89
==========================================
+ Hits 2262 2348 +86
- Misses 117 120 +3 ☔ View full report in Codecov by Sentry. |
…e service repo directory
…add-supervisor-to-down
…3/add-foreground-command
IanWoodard
reviewed
Jun 3, 2025
Contributor
IanWoodard
left a comment
IanWoodard
left a comment
There was a problem hiding this comment.
Looks pretty solid, had some comments about some edge cases. Good job testing as well!
IanWoodard
approved these changes
Jun 3, 2025
Contributor
IanWoodard
left a comment
IanWoodard
left a comment
There was a problem hiding this comment.
One last thing (utilize constants for colors), but after that, looks good to go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the
devservices foregroundcommand.If a service is up and running in a mode where there are supervisor programs, the devservices foreground command stops the daemonized supervisor process. It then brings it up in the foreground, allowing for easier interactive debugging.
When the foregrounded process is terminated, the daemonized process is restarted in the background.
Screen.Recording.2025-05-27.at.11.29.15.AM.mov
https://linear.app/getsentry/issue/DI-656/implement-devservices-foreground-command